-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Enable some nursery lints #15831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Enable some nursery lints #15831
Conversation
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
|
r? @Alexendoo rustbot has assigned @Alexendoo. Use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe putting the lints to enable in a const array and calling .arg() in a loop will be easier to maintain.
|
Don't enable |
73e253e to
dde093f
Compare
|
Per review: Made minor fixes. Cut Extra change: Enabled |
This comment has been minimized.
This comment has been minimized.
|
While there may not be a lot of FPs now, I suspect these lints could become annoying later down the road, when we get bitten by FPs that "break" ci when some of the clippy code changes in the future. |
This comment has been minimized.
This comment has been minimized.
|
Okay, reverted the nursery change. Back to opt-in explicit individual lint enables. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| "clippy::decimal_literal_representation", | ||
| "clippy::derive_partial_eq_without_eq", | ||
| "clippy::iter_on_single_items", | ||
| "clippy::needless_pass_by_ref_mut", | ||
| "clippy::significant_drop_tightening", | ||
| "clippy::tuple_array_conversions", | ||
| "clippy::useless_let_if_seq", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should enable nursery lints here, if we find them useful we should work at getting them out of nursery instead
restriction lints can be fine, but I don't like decimal_literal_representation personally
changelog:noneHello! This PR enables some nursery lints in the dogfood test. For easy review, one lint is enable per commit. They are pretty straightforward (with the exception of
useless_let_if_seq, which gets into some trickier control flow). Only one false positive turned up.Happy to make any changes. Would like to get this merged quickly if possible, to avoid conflicts.
Continuation of #15625 and #15512